Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2470: "Cant register because Client device must be self-signed with a signature matching its own public key" #3496

Conversation

jamalex
Copy link
Member

@jamalex jamalex commented Apr 9, 2015

For now, this is just the regression test, as I want to see whether it fails on Travis.

@jamalex jamalex added the has PR label Apr 9, 2015
@jamalex
Copy link
Member Author

jamalex commented Apr 9, 2015

@aronasorman Looks like there's no need to cherry-pick this against master (0.12), since the code modifying _unhashable_fields didn't yet exist on that branch. The reason 0.12.11 fails is that even though it's doing everything right, the central server is stripping out the description before checking the signature. Merging this to the central server will fix for all clients.

@jamalex jamalex added this to the 0.13.0 milestone Apr 9, 2015
@jamalex jamalex force-pushed the fix_the_evil_bug_that_spoke_softly_and_carried_a_big_stick branch from 656e3cf to ade2bc3 Compare April 9, 2015 21:08
@jamalex jamalex force-pushed the fix_the_evil_bug_that_spoke_softly_and_carried_a_big_stick branch 3 times, most recently from 715b6ec to d1d5e02 Compare April 9, 2015 22:21
@jamalex
Copy link
Member Author

jamalex commented Apr 9, 2015

Ok, got it to fail in the right places, and pass in the right places, I believe. Merging and moving onwards!

(The current failure on the HEAD is a stochastic, unrelated one)

jamalex added a commit that referenced this pull request Apr 9, 2015
…tly_and_carried_a_big_stick

Fixes #2470: "Cant register because Client device must be self-signed with a signature matching its own public key"
@jamalex jamalex merged commit 71f1477 into learningequality:0.13.x Apr 9, 2015
@jamalex jamalex removed the has PR label Apr 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants