smart_translate_item_data: translate strings automatically #3453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See, in smart_translate_item_data we always assumed that a list inside assessment items is always a dict. Now, apparently it always isn't, based on the behaviour we see from KA's code: https://gist.github.com/aronasorman/e8f77ad7444d55c5a5e1#file-models-py-L127 So now we just replicate that behaviour in smart_translate_item_data by translating strings, and returning immediately.
jamalex
added a commit
that referenced
this pull request
Mar 30, 2015
smart_translate_item_data: translate strings automatically
|
Should be fine, as long as all the data that gets passed to the function is On Mon, 30 Mar 2015 13:00 Jamie Alexandre [email protected] wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3413.
Upon reading KA's code we apparently don't translate a list of strings inside an assessment item properly. The symptom of this is the 500 error code which @EdDixon caught. So now, when we see a string (perhaps passed as an argument in
item_data[field] = map(smart_translate_item_data, field_data), we now just translate that string directly.Now also features tests! (tm)