Sidebar now responsive as ever #3209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
February 24, 2015 12:49
Sidebar resizing only detects window resizes in 100px steps to prevent unnecessary computation when user decides to play with the glorious responsiveness.
|
Aaaaand I found a bug just after opening this PR. Resizing window with the sidebar closed makes it appear without actually opening it. Should be easy enough to fix actually. |
|
Aaaaand fixed! That was easy. |
| this.resize_for_narrow(); | ||
| if (this.state_model.get("open")) { | ||
| if ($(window).width() < 1260) | ||
| this.resize_for_narrow(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
We're antsy to merge this, so I'll just add the brackets. |
MCGallaspy
added a commit
that referenced
this pull request
Mar 10, 2015
Sidebar now responsive as ever
|
@MCGallaspy You guys dig it so much, eh? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made some fancy CSS and Backbone changes that make the whole thing embrace various screen sizes more than ever before. I had never thought I'd see this happen anytime soon, but the sidebar now literally behaves like a Bootstrap component, resizing live with the window size. While I feel there is more optimization to do going forward, this is a stable enough update to be merged.
This update builds on top of #3139 and adds the following:
Largest size (> 1300px)
Smallest size (504px)
Suggestions for tweaks and improvements welcome (are the font sizes okay?).