Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix 3040, Redirect to login page in case of Unauthorized #3092

Merged
merged 8 commits into from
Feb 25, 2015
Merged

Fix 3040, Redirect to login page in case of Unauthorized #3092

merged 8 commits into from
Feb 25, 2015

Conversation

anuragkanungo
Copy link
Contributor

Fixes #3040

@anuragkanungo anuragkanungo added this to the Nalanda bugfixes milestone Feb 23, 2015
aronasorman
aronasorman reviewed Feb 24, 2015
View reviewed changes
static-libraries/js/khan-lite.js
case 403:
// Redirect to Login Page and add the current url as next
window.location.href = USER_LOGIN_URL + "?next=" + window.location.href

This comment was marked as spam.

Sign in to view

@aronasorman
Copy link
Collaborator

Please write a test for this.

aronasorman
aronasorman reviewed Feb 24, 2015
View reviewed changes
kalite/distributed/tests/browser_tests/quiz.py

PLAYLIST_ID = "g3_p1"
import urllib

This comment was marked as spam.

Sign in to view

@aronasorman aronasorman assigned aronasorman and unassigned jamalex Feb 24, 2015
@anuragkanungo
Copy link
Contributor Author

Hi @jamalex , can you help me figure out the problem.
As the test which is failing is the one I added and it works fine on my laptop. (It pass)
But it fails for travis.

@MCGallaspy
Copy link
Contributor

@anuragkanungo some of the tests seem to be dependent on the conditions of the machine running them, and we're working to remove these non-deterministic features from the tests. I restarted the build, but if it fails again then someone (perhaps me?) will test it manually before merging.

@aronasorman
Copy link
Collaborator

I'll merge this now, since the fix is needed for a classroom taking a test today. @anuragkanungo please try to investigate why this is failing.

aronasorman added a commit that referenced this pull request Feb 25, 2015
@aronasorman
Merge pull request #3092 from anuragkanungo/nalanda-rct3
7c9085b 
Fix 3040, Redirect to login page in case of Unauthorized
@aronasorman aronasorman merged commit 7c9085b into learningequality:nalanda-rct3 Feb 25, 2015
@anuragkanungo anuragkanungo mentioned this pull request Mar 11, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aronasorman aronasorman

Labels
None yet
Projects
None yet
Milestone
Nalanda bugfixes
Development

Successfully merging this pull request may close these issues.
4 participants
@anuragkanungo @aronasorman @MCGallaspy @jamalex