-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Student Mastery/Class Mastery CoachReports #3033
Added Student Mastery/Class Mastery CoachReports #3033
Conversation
@aronasorman |
@aronasorman |
yessir! |
Haha, Thanks 👍 |
When opening a PR like this, can you please include a description with explanations of what it does, and screenshots of changes made? |
This is going to have substantial merge conflicts with the develop branch (see anuragkanungo/ka-lite@learningequality:develop...anuragkanungo:coach_reports). Are we aiming to abandon the nalanda branches moving forward (i.e. not aim to merge them to develop), and just cherry-pick needed pieces from there into the develop branch? @rtibbles @aronasorman |
I think it makes sense to just complete drop it and then merge piecemeal. We can revisit the PRs merged into nalanda by looking at the |
@anuragkanungo We can review and merge this in, as long as it's understood that this (and the nalanda-* branches in general) won't be getting merged back into the develop branch anymore, as they are diverging too much, and hence any features/fixes that are intended to outlive the RCT will need to be cherry-picked (or redone) onto the develop branch directly (where they will need to pass the "does this belong in the mainline release" criterion, and hence, unlike the process for this PR, should be discussed in detail in an issue, prior to being worked on). |
@@ -0,0 +1,97 @@ | |||
/** |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Given that (as discussed above) this code is temporary (constrained to the nalanda-* branches), I'd be ok merging it as-is, but made some comments regarding the kinds of things that would need to be changed if we were doing this against the mainline branches. |
@jamalex , I did most the changes as you suggested. |
@@ -0,0 +1,97 @@ | |||
/** |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Added Student Mastery/Class Mastery CoachReports
No description provided.