Fix UUID race conditions #2818
Merged
Fix UUID race conditions #2818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return self.devicemetadata | ||
| except DeviceMetadata.DoesNotExist: | ||
| return DeviceMetadata(device=self) | ||
| return DeviceMetadata.objects.get_or_create(device=self)[0] |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @@ -388,16 +388,24 @@ def save(self, imported=False, increment_counters=True, sign=True, *args, **kwar | |||
| def set_id(self): | |||
| self.id = self.id or self.get_uuid() | |||
|
|
|||
| # def get_uuid(self): | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Just one cleanup, then wait for the tests to pass. |
|
Will fix assertion error on the 0.12 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the default
get_uuidmethod calculated the uuid as a function of the device ID and the counter position, but as the function for incrementing/retrieving the counter wasn't properly atomic, this led in some cases to duplicate model ids (and hence likely a couple instances of data loss 😿).This PR does two things:
get_uuidmethod be random (uuid4), rather than being based on the counter.