Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button for English content pack wrongly claims "Delete subtitles" #5232

Closed
benjaoming opened this issue Aug 1, 2016 · 1 comment
Closed

Button for English content pack wrongly claims "Delete subtitles" #5232

benjaoming opened this issue Aug 1, 2016 · 1 comment
Assignees
@benjaoming
Labels
beginner bug
Milestone
0.17.0

Comments

@benjaoming
Copy link
Contributor

Summary

Deleting the English content pack will wipe the content db, so it's not just subtitles that go. Especially not once we stop shipping the en-minimal content db.

Branch or installer method

  • Branch: develop

How to reproduce

  1. Install KA Lite
  2. Upgrade English content pack

Screenshots

screenshot from 2016-08-01 16 25 59

Real-life consequences (anything community should be aware, for instance how it affects your deployment)

This is not a major issue as it's highly unlikely that users will click the button anyways.
@benjaoming benjaoming added this to the 0.17.0 milestone Aug 1, 2016
benjaoming pushed a commit to benjaoming/ka-lite that referenced this issue Oct 2, 2016
Rename 'Delete Subtitles' to simply 'Delete' - fixes learningequality…
9dabbbd 
…#5232
@benjaoming benjaoming mentioned this issue Oct 2, 2016
Merged
@benjaoming benjaoming self-assigned this Oct 2, 2016
@benjaoming
Copy link
Contributor Author

Fixed in #5311

@benjaoming benjaoming removed the has PR label Oct 3, 2016
@benjaoming benjaoming mentioned this issue Nov 15, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjaoming benjaoming

Labels
beginner bug
Projects
None yet
Milestone
0.17.0
Development

No branches or pull requests
1 participant
@benjaoming