Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Login" modal on top of "Create Admin Account" modal #4834

Closed
benjaoming opened this issue Feb 10, 2016 · 1 comment
Closed

"Login" modal on top of "Create Admin Account" modal #4834

benjaoming opened this issue Feb 10, 2016 · 1 comment
Assignees
@66eli77
Labels
bug
Milestone
0.16.0

Comments

@benjaoming
Copy link
Contributor

How to recreate:

  1. Have a clean installation w/o user accounts
  2. Hit a url that's login protected, for instance: http://localhost:8008/update/videos/

Result:
screenshot from 2016-02-10 19 56 29

Expected result: The "Create Admin Account" is always on top.
@benjaoming benjaoming added the bug label Feb 10, 2016
@benjaoming benjaoming added this to the 0.16.0 milestone Feb 10, 2016
@66eli77
Copy link
Contributor

66eli77 commented Feb 16, 2016

yes, I can reduplicate the issue on 0.16.x

66eli77 added a commit to 66eli77/ka-lite that referenced this issue Feb 16, 2016
@66eli77
fix for issue learningequality#4834
b48b38f 
don't display loginModalView when SuperUserCreateModalView is displayed
@66eli77 66eli77 added the has PR label Feb 16, 2016
@MCGallaspy MCGallaspy mentioned this issue Feb 16, 2016
Merged
66eli77 added a commit to 66eli77/ka-lite that referenced this issue Feb 17, 2016
@66eli77
add regression test for login redirect without superusers
6c582f2 
see learningequality#4834
66eli77 added a commit to 66eli77/ka-lite that referenced this issue Feb 17, 2016
@66eli77
fix for issue learningequality#4834
5f20450 
don't display loginModalView when SuperUserCreateModalView is displayed
66eli77 added a commit to 66eli77/ka-lite that referenced this issue Feb 18, 2016
@66eli77
fix for issue learningequality#4834
fb7115b 
don't display loginModalView when SuperUserCreateModalView is displayed

add regression test for login redirect without superusers

see learningequality#4834
@66eli77 66eli77 closed this as completed Mar 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@66eli77 66eli77

Labels
bug
Projects
None yet
Milestone
0.16.0
Development

No branches or pull requests
3 participants
@aronasorman @benjaoming @66eli77