-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After video download finished, you must force to log-in again to download another one. #4204
Comments
I have also been replicating this issue but am being immediately logged off when clicking on the video tab on MAC and Linux 0.14 installations. I do feel it maybe related to #4118 but also on the linux version last tested here, it seemed to be logging me off at random as well. I will try to test a more recent Linux version for more clues or if I can find a means to reliably replicate that. |
Happens too for language packs. However I don't think this should be a release blocker. |
@benjaoming on Debian with version a12 exhibiting same behavior, immediately requiring the admin user to login again with the following security warning in console:
@aron ? escalate to blocker ? sounds important enough? but also easy enough to handle? |
I still feel that it's not a blocker, though it certainly deserves to be fixed. |
Awesome! |
Fixed in 9961909. @radinamatic @amodia or @EdDixon can one of you guys test it out and see if it's fixed on your side? |
Does seem to be fixed, @aronasorman ! 👍 I updated Spanish pack on my 0.14.x branch and I'm downloading Lao (curious to see that one, beautiful letters ;) and it did not log me out. Anyway, I believe you pushed that fix after @MCGallaspy compiled the Windows installer, so make sure it gets included in the final release! |
Nice! Just a word of warning, there are known issues with a combination of SECRET_KEY being public and signed cookies , but they're to be addressed in this issue: #4213 Thanks for testing @radinamatic! Closing. |
Branch:
0.14.x
Expected behavior: Admin user must not log-in again after finish downloading video.
Current behavior: Admin user force to log-in again to download another video.
Steps to reproduce:
This issue may related to #4181
The text was updated successfully, but these errors were encountered: