Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After video download finished, you must force to log-in again to download another one. #4204

Closed
mrpau-richard opened this issue Aug 5, 2015 · 8 comments
Assignees
Milestone

Comments

@mrpau-richard
Copy link
Contributor

Branch: 0.14.x
Expected behavior: Admin user must not log-in again after finish downloading video.
Current behavior: Admin user force to log-in again to download another video.

Steps to reproduce:

  1. Log in as admin.
  2. Navigate to video tab.
  3. Download any video and wait to finish.
  4. Try to download video again and you need to log-in to download another video.

This issue may related to #4181

ka-lite-a

@EdDixon
Copy link
Contributor

EdDixon commented Aug 5, 2015

I have also been replicating this issue but am being immediately logged off when clicking on the video tab on MAC and Linux 0.14 installations. I do feel it maybe related to #4118 but also on the linux version last tested here, it seemed to be logging me off at random as well. I will try to test a more recent Linux version for more clues or if I can find a means to reliably replicate that.

@aronasorman
Copy link
Collaborator

Happens too for language packs. However I don't think this should be a release blocker.

@aronasorman aronasorman added this to the 0.15.0 milestone Aug 5, 2015
@EdDixon
Copy link
Contributor

EdDixon commented Aug 5, 2015

@benjaoming on Debian with version a12 exhibiting same behavior, immediately requiring the admin user to login again with the following security warning in console:

Use of getPreventDefault() is deprecated. Use defaultPrevented instead. 
Password fields present on an insecure (http://) page. This is a security risk that allows user 
login credentials to be stolen.

@aron ? escalate to blocker ? sounds important enough? but also easy enough to handle?

@aronasorman
Copy link
Collaborator

I still feel that it's not a blocker, though it certainly deserves to be fixed.

@EdDixon
Copy link
Contributor

EdDixon commented Aug 5, 2015

Awesome!

aronasorman pushed a commit that referenced this issue Aug 6, 2015
@aronasorman
Copy link
Collaborator

Fixed in 9961909. @radinamatic @amodia or @EdDixon can one of you guys test it out and see if it's fixed on your side?

@radinamatic
Copy link
Member

Does seem to be fixed, @aronasorman ! 👍

I updated Spanish pack on my 0.14.x branch and I'm downloading Lao (curious to see that one, beautiful letters ;) and it did not log me out.

Anyway, I believe you pushed that fix after @MCGallaspy compiled the Windows installer, so make sure it gets included in the final release!

@aronasorman
Copy link
Collaborator

Nice!

Just a word of warning, there are known issues with a combination of SECRET_KEY being public and signed cookies , but they're to be addressed in this issue: #4213

Thanks for testing @radinamatic! Closing.

@mrpau-richard mrpau-richard changed the title After finishing downloading video you must force to log-in again to download another one. After video download finished, you must force to log-in again to download another one. Aug 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants