-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs tweaks for 0.14 #4106
Comments
Flagging @aronasorman and @MCGallaspy in here as well, as they've got their hand in docs, but assigning to @benjaoming as requested. |
Tasks added |
This directory won't exist on Windows XP ( |
Description for CRONSERVER_FREQUENCY: Removed. Changing its value doesn't have any critical effects. Video download jobs are started immediately, anyways. See: https://en.wikipedia.org/wiki/Convention_over_configuration |
CHERRYPY_THREAD_COUNT: As Jamie said, the setting has no effect. Removed from docs, convention over configuration. |
There was a syntax err for the example block, but it came back in a previous PR: http://ka-lite.readthedocs.org/en/0.14.x/usermanual/userman_admin.html#running-ka-lite-with-your-own-settings Yes, the raspberry pi .deb creates a settings module automatically with |
Just in skimming the admin page docs, a huge number of things popped out as wrong. This page (and, I'm guessing others) need a thorough review and update, but I wanted to highlight the main things that popped out at me in my skim.
USE_MPLAYER
setting no longer exists, so this section can be deleted.CRONSERVER_FREQUENCY
: description here is not quite right, as it only actually runs the sync cron job every hour, even though the cronserver runs every 10 mins (by default). Making this smaller won't increase the frequency of syncs, but making it longer than 1 hour will reduce the frequency.should be
CACHE_TIME
: I don't think we're using the Django page cache any more, are we, @rtibbles? In any case, the description of what it does is now out of date.CHERRYPY_THREAD_COUNT
: We now hardcode this as'server.thread_pool': 18,
in kalitectl.py, so this setting won't do anythingThese instructions are incomplete (the example is missing). Also, what will go in the autogenerated settings.py if it's a Raspberry Pi -- will it automatically know to import the RPi base settings? Otherwise, it won't use the RPi settings by default, right?
It would be clearer to have:
be:
Is this currently the correct argument order, after @aronasorman's PR?
We no longer support BTSync. Traditional torrent files should be downloaded from https://learningequality.org/downloads/ka-lite/0.14/content/
is incorrect, and should be changed to:
should be changed to:
The following definitions are confusing and unnecessary, and should be deleted:
benjaoming additions from #4095:
The text was updated successfully, but these errors were encountered: