Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12567 issue #9

Merged
merged 9 commits into from
Nov 27, 2024
Merged

12567 issue #9

merged 9 commits into from
Nov 27, 2024

Conversation

rparadowski
Copy link
Contributor

Summary

Add reusable workflow notify_team_new_comment

References

Issue: learningequality/kolibri#12567
After this PR is merged:
Change banch reference in learningequality/test-actions#53
Create PRs for kolibri, studio, ricecooker, kolibri-design-system

Reviewer guidance

  1. Create Pull request similar to Test notify_team_new_comment workflow test-actions#53
  2. Create issue and link it to PR
  3. Change default repo branch to the branch you are changing in PR from (1.) due to https://docs.github.com/en/actions/writing-workflows/choosing-when-your-workflow-runs/events-that-trigger-workflows#issue_comment
  4. Post comment in issue.

@rparadowski
Copy link
Contributor Author

Tested using rparadowski/test-actions#1

env:
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }}
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK
uses: slackapi/[email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rparadowski - I was wondering if you'd be willing to take on upgrading the action to v2 in the course of this work?

No obligation here, but I suspect we might have to tweak how we invoke the action based on their most recent changes and thought doing it in the course of this work might be feasible: https://github.com/slackapi/slack-github-action/releases/tag/v2.0.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rparadowski I invited my colleague @rtibbles here because it seemed you're on search for another task and this shared action is just on time :)! Otherwise we'd need to do this in three repos.

And after I will have done the testing, @rtibbles will join us for more detailed code review - he's one of the most knowledgeable in this regard on the team.

Thanks both.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, version upgraded and tested:
image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @rparadowski, much appreciated!

@rparadowski rparadowski requested a review from rtibbles November 23, 2024 16:10
@MisRob MisRob merged commit cb001ea into learningequality:main Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants