-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12567 issue #9
12567 issue #9
Conversation
Remove conditions for testing formatting
Alter webhook Use secret
Tested using rparadowski/test-actions#1 |
env: | ||
SLACK_WEBHOOK_URL: ${{ secrets.SLACK_WEBHOOK_URL }} | ||
SLACK_WEBHOOK_TYPE: INCOMING_WEBHOOK | ||
uses: slackapi/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rparadowski - I was wondering if you'd be willing to take on upgrading the action to v2 in the course of this work?
No obligation here, but I suspect we might have to tweak how we invoke the action based on their most recent changes and thought doing it in the course of this work might be feasible: https://github.com/slackapi/slack-github-action/releases/tag/v2.0.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rparadowski I invited my colleague @rtibbles here because it seemed you're on search for another task and this shared action is just on time :)! Otherwise we'd need to do this in three repos.
And after I will have done the testing, @rtibbles will join us for more detailed code review - he's one of the most knowledgeable in this regard on the team.
Thanks both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @rparadowski, much appreciated!
Summary
Add reusable workflow notify_team_new_comment
References
Issue: learningequality/kolibri#12567
After this PR is merged:
Change banch reference in learningequality/test-actions#53
Create PRs for kolibri, studio, ricecooker, kolibri-design-system
Reviewer guidance