Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Python 3.7, switch to Python 3.11 in CI #621

Merged
merged 4 commits into from
Jul 15, 2024
Merged

Conversation

mryab
Copy link
Member

@mryab mryab commented Jul 13, 2024

Python 3.7 has reached end-of-line status almost a year ago, which means that we do not need to support it. This PR removes the code that was used to support it (apart from the MPFuture implementation) and switches Actions runners to use Python 3.11 by default

Copy link
Member

@justheuristic justheuristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jul 15, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.72%. Comparing base (d20e810) to head (cdb87a3).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
hivemind/averaging/matchmaking.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #621      +/-   ##
==========================================
- Coverage   85.39%   84.72%   -0.68%     
==========================================
  Files          81       81              
  Lines        8006     7987      -19     
==========================================
- Hits         6837     6767      -70     
- Misses       1169     1220      +51     
Files with missing lines Coverage Δ
hivemind/utils/asyncio.py 95.34% <100.00%> (-4.66%) ⬇️
hivemind/utils/mpfuture.py 94.14% <100.00%> (+0.81%) ⬆️
hivemind/averaging/matchmaking.py 85.16% <50.00%> (-0.21%) ⬇️

... and 51 files with indirect coverage changes

@mryab mryab merged commit 213bff9 into master Jul 15, 2024
14 checks passed
@mryab mryab deleted the deprecate_python3.7 branch July 15, 2024 22:10
mryab added a commit that referenced this pull request Oct 13, 2024
* Deprecate Python 3.7, switch to Python 3.11 in CI

* Update Sphinx

* Set Sphinx language to "en"

* Increase the timeout for codecov

(cherry picked from commit 213bff9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants