Force DHT to be mp.context.ForkProcess #589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #589 +/- ##
=======================================
Coverage 85.30% 85.30%
=======================================
Files 81 81
Lines 8009 8009
=======================================
Hits 6832 6832
Misses 1177 1177
|
mryab
approved these changes
Aug 31, 2023
mryab
pushed a commit
that referenced
this pull request
Aug 31, 2023
This doesn't change anything on Linux but helps macOS users. Specifically, it's helps to: - Avoid [this error](bigscience-workshop/petals#405 (comment)) for people who don't use `if __name__ == "__main__"` in simple scripts on macOS (that uses spawn for processes by default). - Make DHT consistent with other code that inherits from `mp.context.ForkProcess` directly. (cherry picked from commit 1eb5d18)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This doesn't change anything on Linux but helps macOS users. Specifically, it's helps to:
if __name__ == "__main__"in simple scripts on macOS (that uses spawn for processes by default).mp.context.ForkProcessdirectly.