Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using .lstrip() in hivemind.compression #578

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Fix using .lstrip() in hivemind.compression #578

merged 2 commits into from
Jul 21, 2023

Conversation

borzunov
Copy link
Member

@borzunov borzunov commented Jul 20, 2023

.lstrip() doesn't do what I though it does. In fact, it would remove any prefixes with chars {'t', 'o', 'r', 'c', 'h', '.'}, which is not what we expect (even though it works here).

@codecov
Copy link

codecov bot commented Jul 20, 2023

Codecov Report

Merging #578 (4a07742) into master (ec1d7fe) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #578      +/-   ##
==========================================
- Coverage   85.37%   85.33%   -0.04%     
==========================================
  Files          81       81              
  Lines        8006     8006              
==========================================
- Hits         6835     6832       -3     
- Misses       1171     1174       +3     
Impacted Files Coverage Δ
hivemind/compression/base.py 94.28% <100.00%> (ø)
hivemind/compression/quantization.py 94.82% <100.00%> (ø)

... and 4 files with indirect coverage changes

@borzunov borzunov merged commit da130cd into master Jul 21, 2023
14 checks passed
@borzunov borzunov deleted the no-lstrip branch July 21, 2023 07:59
mryab pushed a commit that referenced this pull request Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants