Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in beam_search.py #532

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Conversation

eltociear
Copy link
Contributor

ther -> there

@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #532 (a3de421) into master (6432353) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head a3de421 differs from pull request most recent head 2ed6ea9. Consider uploading reports for the commit 2ed6ea9 to get more accurate results

@@            Coverage Diff             @@
##           master     #532      +/-   ##
==========================================
- Coverage   75.99%   75.96%   -0.03%     
==========================================
  Files          81       81              
  Lines        7964     7964              
==========================================
- Hits         6052     6050       -2     
- Misses       1912     1914       +2     
Impacted Files Coverage Δ
hivemind/moe/client/beam_search.py 39.02% <ø> (ø)
hivemind/dht/protocol.py 92.23% <0.00%> (-0.92%) ⬇️

@borzunov
Copy link
Member

borzunov commented Dec 9, 2022

Hi @eltociear!

Thanks for pointing out the typo. I believe it's better to write they here.

@borzunov borzunov merged commit 4c9c477 into learning-at-home:master Dec 9, 2022
mryab pushed a commit that referenced this pull request Jan 7, 2023
Co-authored-by: Alexander Borzunov <[email protected]>
(cherry picked from commit 4c9c477)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants