Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bitsandbytes, relax its version constraint #510

Merged
merged 2 commits into from
Oct 12, 2022
Merged

Conversation

mryab
Copy link
Member

@mryab mryab commented Sep 28, 2022

It was reported that the current version of bitsandbytes used in hivemind[bitsandbytes] has an error that prevents it from working properly. The first tested release that we can rely on is 0.34.0, which is what I use in this PR. Also, to provide a bit more compatibility with future patches of this release, I've changed the dependency specification from strict equality to compatibility with future patches of 0.34.

Notably, if a user wants to use newer versions of bitsandbytes in their applications, they can simply install hivemind (without [bitsandbytes]) and bitsandbytes separately: this way, there will be no version conflicts.

@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #510 (7f88a9e) into master (13cdd13) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #510      +/-   ##
==========================================
- Coverage   75.97%   75.94%   -0.04%     
==========================================
  Files          81       81              
  Lines        7943     7943              
==========================================
- Hits         6035     6032       -3     
- Misses       1908     1911       +3     
Impacted Files Coverage Δ
hivemind/dht/node.py 90.28% <0.00%> (-1.66%) ⬇️
hivemind/dht/protocol.py 93.15% <0.00%> (+0.45%) ⬆️
hivemind/moe/server/server.py 44.26% <0.00%> (+0.54%) ⬆️
hivemind/moe/server/runtime.py 70.00% <0.00%> (+0.83%) ⬆️
hivemind/moe/server/connection_handler.py 47.91% <0.00%> (+1.04%) ⬆️

@mryab mryab merged commit 44d9569 into master Oct 12, 2022
@mryab mryab deleted the bump_bitsandbytes branch October 12, 2022 20:57
mryab added a commit that referenced this pull request Oct 19, 2022
* Update bitsandbytes, relax its version constraint

(cherry picked from commit 44d9569)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants