Fix a potential deadlock in await_asynchronously with nested locks #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #503 +/- ##
==========================================
- Coverage 86.31% 86.17% -0.15%
==========================================
Files 81 81
Lines 7871 7884 +13
==========================================
Hits 6794 6794
- Misses 1077 1090 +13
|
borzunov
reviewed
Aug 29, 2022
borzunov
approved these changes
Aug 29, 2022
mryab
pushed a commit
that referenced
this pull request
Sep 13, 2022
) This PR fixes a potential deadlock in hivemind.utils.enter_asynchronously. This deadlock occurs when many coroutines enter nested locks and exhaust all workers in ThreadPoolExecutor. In this PR, we mitigate it by creating a dedicated executor for entering locks with no limit to the number of workers. Co-authored-by: Aleksandr Borzunov <[email protected]> (cherry picked from commit b02bdad)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered by @borzunov when reviewing bigscience-workshop/petals#53
Please see the test description in files_changed for more details