Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up imports, remove unused utils #486

Merged
merged 3 commits into from
Jun 16, 2022
Merged

Clean up imports, remove unused utils #486

merged 3 commits into from
Jun 16, 2022

Conversation

mryab
Copy link
Member

@mryab mryab commented Jun 16, 2022

No description provided.

@mryab mryab requested a review from justheuristic June 16, 2022 12:29
@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #486 (8701ade) into master (5ea21a7) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #486      +/-   ##
==========================================
- Coverage   85.82%   85.76%   -0.06%     
==========================================
  Files          80       80              
  Lines        7808     7793      -15     
==========================================
- Hits         6701     6684      -17     
- Misses       1107     1109       +2     
Impacted Files Coverage Δ
hivemind/utils/asyncio.py 100.00% <ø> (ø)
hivemind/utils/networking.py 29.62% <ø> (-13.62%) ⬇️
hivemind/averaging/key_manager.py 95.00% <100.00%> (ø)
hivemind/averaging/matchmaking.py 87.50% <100.00%> (-0.30%) ⬇️
hivemind/dht/__init__.py 100.00% <100.00%> (ø)
hivemind/dht/routing.py 94.11% <100.00%> (ø)
hivemind/moe/client/beam_search.py 56.91% <100.00%> (ø)
hivemind/moe/server/dht_handler.py 98.24% <100.00%> (ø)
hivemind/p2p/p2p_daemon.py 94.34% <100.00%> (ø)
hivemind/p2p/p2p_daemon_bindings/datastructures.py 73.58% <100.00%> (ø)
... and 8 more

Copy link
Member

@justheuristic justheuristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Let's ship it :)

@mryab mryab merged commit bc2cccf into master Jun 16, 2022
@mryab mryab deleted the clean_imports branch June 16, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants