Remove gRPC services and grpcio requirement #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mryab
force-pushed
the
remove_grpc_compilation
branch
from
2d4d119
to
0d77199
Compare
|
Checked that keeping |
Codecov Report
@@ Coverage Diff @@
## master #485 +/- ##
==========================================
+ Coverage 85.57% 85.82% +0.24%
==========================================
Files 80 80
Lines 7794 7794
==========================================
+ Hits 6670 6689 +19
+ Misses 1124 1105 -19
|
README.md
Outdated
| @@ -53,6 +53,7 @@ To install hivemind from source, simply run the following: | |||
| ``` | |||
| git clone https://github.com/learning-at-home/hivemind.git | |||
| cd hivemind | |||
| pip install "grpcio-tools>=1.33.2" # for protobuf compilation | |||
There was a problem hiding this comment.
Shall we say pip install -r requirements-dev.txt instead?
Rationale: less chance that we forget to update the version later.
There was a problem hiding this comment.
It is, check the diff and PR description. The rationale is that you don't need to install all the development deps just to make hivemind work
There was a problem hiding this comment.
Okay, have it your way :)
There was a problem hiding this comment.
And regarding the "forget to update later" part: we haven't bumped this requirement for the past 2 years and are unlikely to to do this soon, so I'm not sure if this is something that we should worry about
There was a problem hiding this comment.
This line is not okay for me, such things should be moved to requirements (that's exactly what requirements are for).
There was a problem hiding this comment.
Again, it is present in the development requirements file. The issue is that we do not need this package at runtime when we are installing hivemind normally (e.g. from pip), so a regular user should not need to install it (because the pip-installed version contains already compiled protobuf files)
mryab
force-pushed
the
remove_grpc_compilation
branch
from
50df916
to
8ef54b6
Compare
borzunov
requested changes
Jun 16, 2022
README.md
Outdated
| @@ -53,6 +53,7 @@ To install hivemind from source, simply run the following: | |||
| ``` | |||
| git clone https://github.com/learning-at-home/hivemind.git | |||
| cd hivemind | |||
| pip install "grpcio-tools>=1.33.2" # for protobuf compilation | |||
There was a problem hiding this comment.
This line is not okay for me, such things should be moved to requirements (that's exactly what requirements are for).
This reverts commit 023a8e9.
mryab
force-pushed
the
remove_grpc_compilation
branch
from
b7b5f6b
to
bd55eb3
Compare
mryab
changed the title
borzunov
approved these changes
Jun 17, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the gRPC service definitions from hivemind/proto. Also, since we only need grpcio when compiling the proto files, I've moved them to the development dependencies (installed automatically if you use
pip install -e .[dev], can be installed manually if you are not interested in tests)