Fix offloaded optimizer with single peer #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #450 +/- ##
==========================================
+ Coverage 83.72% 84.10% +0.37%
==========================================
Files 78 78
Lines 7928 7931 +3
==========================================
+ Hits 6638 6670 +32
+ Misses 1290 1261 -29
|
borzunov
reviewed
Jan 19, 2022
| @@ -618,6 +618,12 @@ def _load_averaged_gradients_into_optimizer_(self): | |||
|
|
|||
| self.grad_averager.notify_used_averaged_gradients() | |||
|
|
|||
| def _load_local_gradients_into_optimizer(self): | |||
| """Fallback to using local gradients in the optimizer (instead of averaged gradients)""" | |||
| logger.log(self.status_loglevel, f"Proceeding with local gradients") | |||
There was a problem hiding this comment.
Please add a comment that this can be optimized in case of one peer (if we'd ever need to optimize this case).
borzunov
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug was originally found by @elricwan and @finger92 (seemingly independently) and reported in #447
Here's what was caused the issue:
The bug was introduced in #440 and affects the following setups (all 3 must be true):
Here's the behavior after the fix is introduced:
