Make target group size optional #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #412 +/- ##
==========================================
+ Coverage 84.50% 84.58% +0.08%
==========================================
Files 76 76
Lines 7280 7286 +6
==========================================
+ Hits 6152 6163 +11
+ Misses 1128 1123 -5
|
mryab
approved these changes
Nov 18, 2021
|
Maybe this parameter also isn't necessary in compression tests and examples/docs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request makes target_group_size optional, to avoid bothering user with setting it.
The rationale here is that in most cases we ended up using
target_group_size=some_very_large_number_please_be_large_enough.Therefore, it would make sense to make this a default choice to avoid concerning users with the extra low-level kwarg.