[hivemind.Optimizer] TrainingStateAverager #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Roman Zhytar <[email protected]>
Co-authored-by: Roman Zhytar <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #407 +/- ##
==========================================
+ Coverage 83.84% 84.15% +0.31%
==========================================
Files 74 75 +1
Lines 6783 7121 +338
==========================================
+ Hits 5687 5993 +306
- Misses 1096 1128 +32
|
Co-authored-by: Roman Zhytar <[email protected]> Co-authored-by: Anton Sinitsin <[email protected]> Co-authored-by: Max Ryabinin <[email protected]>
borzunov
reviewed
Nov 15, 2021
|
Note to a potential @mryab : despite running 20 optimizer steps, the test runs in ~1.3s on my laptop and ~2s in the CI. |
borzunov
reviewed
Nov 15, 2021
Co-authored-by: Alexander Borzunov <[email protected]>
Co-authored-by: Alexander Borzunov <[email protected]>
Co-authored-by: Alexander Borzunov <[email protected]>
…d into state_averaging
borzunov
reviewed
Nov 15, 2021
Co-authored-by: Alexander Borzunov <[email protected]>
borzunov
approved these changes
Nov 15, 2021
Co-authored-by: Alexander Borzunov <[email protected]>
Co-authored-by: Alexander Borzunov <[email protected]>
Co-authored-by: Alexander Borzunov <[email protected]>
|
Note: this implements delayed optimizer step as a part of #394 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a component of hivemind.Optimizer ( #400 ) that holds the training state and supports (delayed) optimizer steps and averaging rounds.
Unlike TrainingAverager, this class is does not need data locks as it will only update model parameters during .step.