Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loglevel for a message in _read_from_persistent_conn() #364

Merged
merged 2 commits into from
Aug 25, 2021

Conversation

borzunov
Copy link
Member

@borzunov borzunov commented Aug 25, 2021

This PR hides the following harmless log message:

[2021/08/25 19:15:06.997][WARN][p2p.p2p_daemon_bindings.control._read_from_persistent_conn:189] Received unexpected response from daemon: callId: ":h\234\204\210\250@\233\223J\013V\232\033z\246"
daemonError {
  message: "context canceled"
}

It happens on every cancelled unary call. A better fix (never send a response to a cancelled call) will be implemented in the next p2p daemon release by @deniskamazur.

@borzunov borzunov requested review from mryab and dvmazur August 25, 2021 16:28
@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #364 (6d0565c) into master (a1bb356) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #364      +/-   ##
==========================================
- Coverage   83.40%   83.35%   -0.05%     
==========================================
  Files          66       66              
  Lines        6097     6097              
==========================================
- Hits         5085     5082       -3     
- Misses       1012     1015       +3     
Impacted Files Coverage Δ
hivemind/p2p/p2p_daemon_bindings/control.py 92.54% <100.00%> (ø)
hivemind/dht/node.py 90.69% <0.00%> (-0.72%) ⬇️

@borzunov borzunov merged commit 00eaa47 into master Aug 25, 2021
@borzunov borzunov deleted the change-loglevel branch August 25, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants