Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add less comparator for PeerID #353

Merged
merged 4 commits into from
Aug 18, 2021
Merged

Add less comparator for PeerID #353

merged 4 commits into from
Aug 18, 2021

Conversation

dvmazur
Copy link
Collaborator

@dvmazur dvmazur commented Aug 18, 2021

This PR implements a __less__ comparator for PeerID.
image

@dvmazur dvmazur requested a review from borzunov August 18, 2021 17:01
@codecov
Copy link

codecov bot commented Aug 18, 2021

Codecov Report

Merging #353 (73b5d7c) into master (cf31951) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #353      +/-   ##
==========================================
- Coverage   83.19%   83.19%   -0.01%     
==========================================
  Files          66       66              
  Lines        5987     5991       +4     
==========================================
+ Hits         4981     4984       +3     
- Misses       1006     1007       +1     
Impacted Files Coverage Δ
hivemind/p2p/p2p_daemon_bindings/datastructures.py 74.03% <100.00%> (+1.03%) ⬆️
hivemind/averaging/matchmaking.py 83.18% <0.00%> (-0.31%) ⬇️

Copy link
Member

@borzunov borzunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My recent commits with changes are approved by @deniskamazur as well.

@dvmazur dvmazur merged commit dd05abb into master Aug 18, 2021
@dvmazur dvmazur deleted the less-for-peerid branch August 18, 2021 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants