Refactor naming and serialization for PeerIDs #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #339 +/- ##
==========================================
- Coverage 83.38% 83.23% -0.16%
==========================================
Files 66 66
Lines 5981 5975 -6
==========================================
- Hits 4987 4973 -14
- Misses 994 1002 +8
|
justheuristic
approved these changes
Jul 28, 2021
| @@ -32,7 +25,6 @@ enum MessageCode { | |||
| } | |||
|
|
|||
| message JoinRequest { | |||
| string endpoint = 1; // A follower accepts incoming allreduce requests at this address | |||
| bytes schema_hash = 2; // A hash that describes follower's tensors (shapes, num tensors, etc) | |||
There was a problem hiding this comment.
[the resulting protobuf starts from index=2; discussed with @borzunov and decided to keep it that way unless someone has strong objections]
justheuristic
approved these changes
Jul 28, 2021
yhn112
approved these changes
Jul 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows #323 and does the remaining mass refactors (we've agreed on the most of them in comments to #323):
EndpointtoPeerIDin averager (+ related variable names)P2P.idfield toP2P.peer_id(because the local peer ID is stored in the.peer_idfields in all other classes)PeerIDs asbytesinstead of Base58 stringJoinRequest.peer_idandAveragingData.peer_idfields (they duplicatecontext.remote_id)DecentralizedAveraginggRPC interface (not used anymore)