-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert DHT to libp2p backend #296
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
borzunov
force-pushed
the
dht-over-p2p
branch
2 times, most recently
from
July 10, 2021 05:13
8c567eb
to
3c9e859
Compare
mryab
approved these changes
Jul 10, 2021
This was referenced Jul 11, 2021
borzunov
added a commit
that referenced
this pull request
Jul 11, 2021
This PR follows #296, removes importing PeerID as Endpoint in dht/{node,protocol,routing}.py and related tests, and performs a number of replacements like Endpoint -> PeerID and endpoint -> peer_id.
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current status: finishing the docs and minor details, ready for review.
What I have tested:
examples/albert
, bothrun_training_monitor.py
andrun_trainer.py
work. Training with 2 GPU peers + 1 training monitor performs successful averagings and gradually reduces the loss.Plan:
hivemind.dht.DHT
work over P2Ptest_dht_node.py
test_dht.py
test_dht_*.py
run_training_monitor.py
Details:
test_dht_node.py
Ideas for future PRs:
use_ipfs=True
StreamWriter.write
sdo_handle_stream()
: send data in chunks, call drain(), don't concat a big string with its sizeRelated issues: #91 #149 #165 #185 #238