Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add p2pd to package_data #287

Merged
merged 1 commit into from
Jun 22, 2021
Merged

Add p2pd to package_data #287

merged 1 commit into from
Jun 22, 2021

Conversation

mryab
Copy link
Member

@mryab mryab commented Jun 22, 2021

Previously, we did not include compiled p2pd in the built version of hivemind; as a result, wheels published to PyPI do not contain the installation of p2pd. This PR ensures that the installation includes p2pd by adding it (and other contents of hivemind_cli) to package_data. The following commands succeed now:

$ pip install -U --extra-index-url https://pypi.org/simple -i https://test.pypi.org/simple/ hivemind==0.9.9.post1
Looking in indexes: https://test.pypi.org/simple/, https://pypi.org/simple
Collecting hivemind==0.9.9.post1
  Downloading https://test-files.pythonhosted.org/packages/ba/3f/d44dd71843717a51784048c3de86a5fc047e5ad5823c4e0800a4d8b6057b/hivemind-0.9.9.post1-py3-none-any.whl (14.3 MB)
     |████████████████████████████████| 14.3 MB 6.6 MB/s
[omitted for brevity]
Installing collected packages: hivemind
  Attempting uninstall: hivemind
    Found existing installation: hivemind 0.9.9
    Uninstalling hivemind-0.9.9:
      Successfully uninstalled hivemind-0.9.9
Successfully installed hivemind-0.9.9.post1
$ python -m asyncio
asyncio REPL 3.8.8 (default, Feb 24 2021, 21:46:12)
[GCC 7.3.0] on linux
Use "await" directly instead of "asyncio.run()".
Type "help", "copyright", "credits" or "license" for more information.
>>> import asyncio
>>> import hivemind
>>> p2p=await hivemind.p2p.P2P.create()
Control socket: /ip4/127.0.0.1/tcp/42347
Peer ID: Qmexc5u96H7qt8WnXDxnKT3DDPkmtvRvVnRViaKCFcqr1p
Peer Addrs:
/ip4/172.27.77.70/udp/48885/quic
/ip4/127.0.0.1/udp/48885/quic
/ip4/172.27.77.70/tcp/48885
/ip4/127.0.0.1/tcp/48885
>>>

@mryab mryab requested a review from dvmazur June 22, 2021 22:33
@borzunov borzunov self-requested a review June 22, 2021 22:35
@mryab mryab merged commit b44d860 into master Jun 22, 2021
@mryab mryab deleted the wheel_p2pd branch June 22, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants