-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix random freezes in averager.step, improve error handling #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So, here's how this might explain the error reported earlier by @nevec :
Maybe
|
justheuristic
changed the title
Patch random hanging and errors
Fixed random hangs in averager.step, improved error handling
May 6, 2021
mryab
changed the title
Fixed random hangs in averager.step, improved error handling
Fix random hangs in averager.step, improve error handling
May 6, 2021
mryab
changed the title
Fix random hangs in averager.step, improve error handling
Fix random freezes in averager.step, improve error handling
May 6, 2021
mryab
approved these changes
May 6, 2021
mryab
reviewed
May 6, 2021
@@ -199,6 +200,10 @@ async def request_join_group(self, leader: Endpoint, expiration_time: DHTExpirat | |||
if call is not None: | |||
call.cancel() | |||
return None | |||
except (grpc.RpcError, grpc.aio.AioRpcError, InternalError, StopAsyncIteration) as e: | |||
logger.warning(f"{self} - failed to request potential leader {leader}: {e}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
logger.warning(f"{self} - failed to request potential leader {leader}: {e}") | |
logger.exception(f"{self} - failed to request potential leader {leader}: {e}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed it, thanks
borzunov
reviewed
May 6, 2021
borzunov
approved these changes
May 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces three changes:
DecentralizedAverager
would randomly hang on pytorch ops: Deadlock with multiprocessing (using fork) and OpenMP / PyTorch should warn after OMP and fork that multithreading may be broken pytorch/pytorch#17199DecentralizedAverager._step
so that it is no longer triggered by sanctioned retriesMatchmaking.request_join_group
to handle RPC errors instead of cancelling the entire matchmaking