Add gradient buffers to CollaborativeOptimizer #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
justheuristic
commented
Apr 14, 2021
•
justheuristic
commented
- added an option to accumulate gradients locally (default = True, can be disabled to save some memory, not critical in tutorials)
- fixed a bug in CollaborativeOptimizer that caused it to implicitly scale all updates by self.local_steps_accumulated
- fixed typos in description
justheuristic
requested review from
mryab and
leshanbog
and removed request for
mryab
mryab
requested changes
Apr 14, 2021
Co-authored-by: Max Ryabinin <[email protected]>
Co-authored-by: Max Ryabinin <[email protected]>
leshanbog
approved these changes
Apr 14, 2021
mryab
changed the title
mryab
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.