Fix LibP2P-Daemon installation in setup.py #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvmazur
requested review from
xtinkt and
justheuristic
and removed request for
xtinkt
justheuristic
approved these changes
Mar 17, 2021
|
:note from @mryab :
|
mryab
requested changes
Mar 18, 2021
setup.py
Outdated
Comment on lines
53
to
55
| def install_libp2p_daemon(build=False): | ||
| # verify golang installation if build flag is specified | ||
| if build: |
There was a problem hiding this comment.
In essence, you have two functions with entirely different code. It's best to separate them into two functions with different names
mryab
requested changes
Mar 19, 2021
setup.py
Outdated
Comment on lines
89
to
90
| with cd(os.path.join(tempdir, 'go-libp2p-daemon-master', 'p2pd')): | ||
| status = os.system(f'go build -o {os.path.join(here, "hivemind/hivemind_cli", "p2pd")}') |
There was a problem hiding this comment.
Not sure whether the class cd is necessary. You can use the cwd argument for subprocess.run if you need to change the directory for your command
setup.py
Outdated
Comment on lines
81
to
82
| url = 'https://github.com/libp2p/go-libp2p-daemon/archive/master.tar.gz' | ||
| dest = os.path.join(tempdir, 'libp2p-daemon.tar.gz') | ||
| dest = os.path.join(tempdir, 'libp2p-daemon.tar.gz') |
There was a problem hiding this comment.
Need to change the URL to learning-at-home and to pin the version
.circleci/config.yml
Outdated
Comment on lines
12
to
15
| - run: | | ||
| wget https://golang.org/dl/go1.16.2.linux-amd64.tar.gz | ||
| tar -C ~/ -xzf go1.16.2.linux-amd64.tar.gz | ||
| echo "export PATH=~/go/bin:$PATH" >> $BASH_ENV |
There was a problem hiding this comment.
Better to parametrize Go versions for all three pipelines with something like pipeline variables
setup.py
Outdated
| def md5(fname): | ||
| hash_md5 = hashlib.md5() | ||
| with open(fname, "rb") as f: | ||
| for chunk in iter(lambda: f.read(4096), b""): |
There was a problem hiding this comment.
Move 4096 to a constant or at least an argument with default value
mryab
approved these changes
Mar 19, 2021
justheuristic
pushed a commit
that referenced
this pull request
Apr 13, 2021
* Rename ProtoCompileInstall and ProtoCompileDevelop to Install and Develop * Install LibP2P-Daemon on setup install and setup develop * Install Golang in Circle CI builds * Add P2PD binary to gitignore
MaximKsh
pushed a commit
that referenced
this pull request
Apr 20, 2021
* Rename ProtoCompileInstall and ProtoCompileDevelop to Install and Develop * Install LibP2P-Daemon on setup install and setup develop * Install Golang in Circle CI builds * Add P2PD binary to gitignore
MaximKsh
pushed a commit
that referenced
this pull request
May 14, 2021
* Rename ProtoCompileInstall and ProtoCompileDevelop to Install and Develop * Install LibP2P-Daemon on setup install and setup develop * Install Golang in Circle CI builds * Add P2PD binary to gitignore
MaximKsh
pushed a commit
that referenced
this pull request
May 14, 2021
* Rename ProtoCompileInstall and ProtoCompileDevelop to Install and Develop * Install LibP2P-Daemon on setup install and setup develop * Install Golang in Circle CI builds * Add P2PD binary to gitignore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ProtoCompileInstallandProtoCompileDeveloptoInstallandDevelop