Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Averaging part2 #123

Merged
merged 79 commits into from
Dec 29, 2020
Merged

Averaging part2 #123

merged 79 commits into from
Dec 29, 2020

Commits on Nov 22, 2020

  1. better handle timeout

    @justheuristic
    justheuristic committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    b1a0814 View commit details
    Browse the repository at this point in the history

  2. more careful exceptions

    @justheuristic
    justheuristic committed Nov 22, 2020
    Configuration menu
    Copy the full SHA
    3d70fb5 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2020

  1. please specify list/tuple

    @justheuristic
    justheuristic committed Nov 26, 2020
    Configuration menu
    Copy the full SHA
    8d11334 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2020

  1. max discrepancy

    @justheuristic
    justheuristic committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    a722fd0 View commit details
    Browse the repository at this point in the history

  2. DHT declare/get averagers

    @justheuristic
    justheuristic committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    28a60a1 View commit details
    Browse the repository at this point in the history

  3. unused

    @justheuristic
    justheuristic committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    6e0f7d7 View commit details
    Browse the repository at this point in the history

  4. basic test for DHT.*averager*

    @justheuristic
    justheuristic committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    ac2d450 View commit details
    Browse the repository at this point in the history

  5. typo

    @justheuristic
    justheuristic committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    c6a5aa1 View commit details
    Browse the repository at this point in the history

  6. update group pattern

    @justheuristic
    justheuristic committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    5739c31 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2020

  1. WIP

    @justheuristic
    justheuristic committed Nov 28, 2020
    Configuration menu
    Copy the full SHA
    2d384fd View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2020

  1. move averager test to the respective file

    @justheuristic
    justheuristic committed Dec 1, 2020
    Configuration menu
    Copy the full SHA
    8a4cf53 View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. WIP

    @justheuristic
    justheuristic committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    d248c3a View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2020

  1. WIP

    @justheuristic
    justheuristic committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    5222d17 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2020

  1. pep8

    @justheuristic
    justheuristic committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    3de4eec View commit details
    Browse the repository at this point in the history

  2. fix test_allreduce_protocol, remove obsolete comments

    @justheuristic
    justheuristic committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    f2a35da View commit details
    Browse the repository at this point in the history

  3. implement _run_allreduce

    @justheuristic
    justheuristic committed Dec 10, 2020
    Configuration menu
    Copy the full SHA
    05b493d View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2020

  1. WIP

    @justheuristic
    justheuristic committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    ef70b48 View commit details
    Browse the repository at this point in the history

  2. allreduce_group -> GroupKey

    @justheuristic
    justheuristic committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    81677e0 View commit details
    Browse the repository at this point in the history

  3. separate matchmaker and allreduce

    @justheuristic
    justheuristic committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    c82d55d View commit details
    Browse the repository at this point in the history

  4. move averager

    @justheuristic
    justheuristic committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    2e70488 View commit details
    Browse the repository at this point in the history

  5. use lock_looking_for_group

    @justheuristic
    justheuristic committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    c016edb View commit details
    Browse the repository at this point in the history

  6. use lock_looking_for_group

    @justheuristic
    justheuristic committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    87e55a3 View commit details
    Browse the repository at this point in the history

  7. extract non-matchmaker parameters to averager core

    @justheuristic
    justheuristic committed Dec 13, 2020
    Configuration menu
    Copy the full SHA
    57d879e View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2020

  1. finalize refactor (except for docstrings)

    @justheuristic
    justheuristic committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    7e1df43 View commit details
    Browse the repository at this point in the history

  2. move averager

    @justheuristic
    justheuristic committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    c93dec1 View commit details
    Browse the repository at this point in the history

  3. typo

    @justheuristic
    justheuristic committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    e7c57c4 View commit details
    Browse the repository at this point in the history

  4. fix lfg

    @justheuristic
    justheuristic committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    82a8b3a View commit details
    Browse the repository at this point in the history

  5. test averaging over DHT

    @justheuristic
    justheuristic committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    e298ca1 View commit details
    Browse the repository at this point in the history

  6. test averaging over DHT

    @justheuristic
    justheuristic committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    51d0540 View commit details
    Browse the repository at this point in the history

Commits on Dec 26, 2020

  1. address mryab review part 1

    @mryab @justheuristic
    mryab authored and justheuristic committed Dec 26, 2020
    Configuration menu
    Copy the full SHA
    0a01d0e View commit details
    Browse the repository at this point in the history

  2. check that peer is not self.endpoint

    @mryab @justheuristic
    mryab authored and justheuristic committed Dec 26, 2020
    Configuration menu
    Copy the full SHA
    24f539c View commit details
    Browse the repository at this point in the history

  3. simpler try-except

    @mryab @justheuristic
    mryab authored and justheuristic committed Dec 26, 2020
    Configuration menu
    Copy the full SHA
    a73f370 View commit details
    Browse the repository at this point in the history

  4. Update hivemind/client/averaging/matchmaking.py 

    Co-authored-by: Max Ryabinin <[email protected]>
    @justheuristic @mryab
    justheuristic and mryab authored Dec 26, 2020
    Configuration menu
    Copy the full SHA
    fabae94 View commit details
    Browse the repository at this point in the history

  5. extract reasons to reject into a separate method

    @justheuristic
    justheuristic committed Dec 26, 2020
    Configuration menu
    Copy the full SHA
    df9637a View commit details
    Browse the repository at this point in the history

  6. simplify code

    @justheuristic
    justheuristic committed Dec 26, 2020
    Configuration menu
    Copy the full SHA
    7f863f3 View commit details
    Browse the repository at this point in the history

  7. rename group allreduce => allreduce group

    @mryab @justheuristic
    mryab authored and justheuristic committed Dec 26, 2020
    Configuration menu
    Copy the full SHA
    9e7aa09 View commit details
    Browse the repository at this point in the history

  8. redundant comment

    @justheuristic
    justheuristic committed Dec 26, 2020
    Configuration menu
    Copy the full SHA
    2d79821 View commit details
    Browse the repository at this point in the history

  9. redundant comment

    @justheuristic
    justheuristic committed Dec 26, 2020
    Configuration menu
    Copy the full SHA
    2adb444 View commit details
    Browse the repository at this point in the history

  10. unused variable

    @justheuristic
    justheuristic committed Dec 26, 2020
    Configuration menu
    Copy the full SHA
    11cb357 View commit details
    Browse the repository at this point in the history

  11. revert to working request_join_group (avoid acquiring lock_request_jo… 

    …in_group when not needed)
    @justheuristic
    justheuristic committed Dec 26, 2020
    Configuration menu
    Copy the full SHA
    2419ca2 View commit details
    Browse the repository at this point in the history

  12. remove debugprints

    @justheuristic
    justheuristic committed Dec 26, 2020
    Configuration menu
    Copy the full SHA
    6ea7d29 View commit details
    Browse the repository at this point in the history

  13. move to top

    @mryab @justheuristic
    mryab authored and justheuristic committed Dec 26, 2020
    Configuration menu
    Copy the full SHA
    6483fdf View commit details
    Browse the repository at this point in the history

  14. unused modules

    @justheuristic
    justheuristic committed Dec 26, 2020
    Configuration menu
    Copy the full SHA
    d1ca4ff View commit details
    Browse the repository at this point in the history

  15. pep8

    @justheuristic
    justheuristic committed Dec 26, 2020
    Configuration menu
    Copy the full SHA
    1c47781 View commit details
    Browse the repository at this point in the history

  16. pep8

    @justheuristic
    justheuristic committed Dec 26, 2020
    Configuration menu
    Copy the full SHA
    5612805 View commit details
    Browse the repository at this point in the history

  17. pep8typos

    @justheuristic
    justheuristic committed Dec 26, 2020
    Configuration menu
    Copy the full SHA
    0bff4ef View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2020

  1. WIP: everything except PotentialLeaders

    @justheuristic
    justheuristic committed Dec 27, 2020
    Configuration menu
    Copy the full SHA
    b05f581 View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2020

  1. update leader queue

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    5470ad1 View commit details
    Browse the repository at this point in the history

  2. typo, stricter update_finished

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    7f5e94f View commit details
    Browse the repository at this point in the history

  3. better comment

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    98803c3 View commit details
    Browse the repository at this point in the history

  4. better comment

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    94385cf View commit details
    Browse the repository at this point in the history

  5. tempfix tests

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    e5ecfe3 View commit details
    Browse the repository at this point in the history

  6. Review by mryab

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    51ad83a View commit details
    Browse the repository at this point in the history

  7. Review by mryab

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    18ff9f7 View commit details
    Browse the repository at this point in the history

  8. Review by mryab

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    cb7e02e View commit details
    Browse the repository at this point in the history

  9. Review by mryab

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    9aada8c View commit details
    Browse the repository at this point in the history

  10. Review by mryab

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    785e942 View commit details
    Browse the repository at this point in the history

  11. Review by mryab

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    4bbe0c7 View commit details
    Browse the repository at this point in the history

  12. Review by mryab

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    aaa5d33 View commit details
    Browse the repository at this point in the history

  13. Review by mryab

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    a014f5d View commit details
    Browse the repository at this point in the history

  14. Review by mryab

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    d906079 View commit details
    Browse the repository at this point in the history

  15. Review by mryab

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    6ed3633 View commit details
    Browse the repository at this point in the history

  16. Review by mryab

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    98d0076 View commit details
    Browse the repository at this point in the history

  17. better type annotation

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    e234880 View commit details
    Browse the repository at this point in the history

  18. better type annotation

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    af56c05 View commit details
    Browse the repository at this point in the history

  19. PotentialLeaders

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    58e0781 View commit details
    Browse the repository at this point in the history

  20. naming convention

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    1f871d2 View commit details
    Browse the repository at this point in the history

  21. move cond inside try

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    8675149 View commit details
    Browse the repository at this point in the history

  22. raise PROTOCOL_VIOLATION if len(request.ListFields()) != 3

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    d798200 View commit details
    Browse the repository at this point in the history

  23. shuffle endpoints in a group

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    1b3556e View commit details
    Browse the repository at this point in the history

  24. review by mryab

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    1cc21d4 View commit details
    Browse the repository at this point in the history

  25. review by mryab@

    @mryab @justheuristic
    mryab authored and justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    df3f47d View commit details
    Browse the repository at this point in the history

  26. review by mryab@

    @mryab @justheuristic
    mryab authored and justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    85bbd6a View commit details
    Browse the repository at this point in the history

  27. review by mryab@

    @mryab @justheuristic
    mryab authored and justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    3a541fe View commit details
    Browse the repository at this point in the history

  28. review by mryab@

    @mryab @justheuristic
    mryab authored and justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    9591ef9 View commit details
    Browse the repository at this point in the history

  29. review by mryab@

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    8d0ebf2 View commit details
    Browse the repository at this point in the history

  30. get rid of dhtid

    @justheuristic
    justheuristic committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    26ec96f View commit details
    Browse the repository at this point in the history

  31. Merge branch 'master' into averaging_part2 

    # Conflicts:
#	hivemind/__init__.py
#	hivemind/client/averager.py
    @mryab
    mryab committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    bdea2f1 View commit details
    Browse the repository at this point in the history

  32. Post-merge fixes

    @mryab
    mryab committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    e52534c View commit details
    Browse the repository at this point in the history