Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster beam search part2/2 #101

Closed
wants to merge 16 commits into from
Closed

Conversation

justheuristic
Copy link
Member

@justheuristic justheuristic commented Sep 16, 2020

we're currently trying alternative solution in #103, this PR will not receive updates for several days

  • add beam search function to hivemind.dht.DHT (rationale: reduce inter-process communication)
  • add batch-parallel beam search
  • add option for limited time_budget in beam search
  • DHT, DHTNode: shutdown on __del__ (LATER)
  • CircleCI: rollback changes from part1 (was: temporary failure on their side)
  • remove beam search from moe.py
  • add tests for all new functionality
    • get/store locally
    • find_best_experts
    • batch_find_best_experts
  • add beam search benchmark to benchmark_dht

On time budget: if time_budget != float('inf'), beam search will send requests to peers only within this budget and return best experts it could find in cache

@justheuristic justheuristic changed the title Faster beam search part2 Faster beam search part2/2 Sep 16, 2020
@justheuristic
Copy link
Member Author

Sorry for the delay, im back after ICLR

@Maria1007
Copy link

Maria1007 commented Sep 30, 2020 via email

@justheuristic
Copy link
Member Author

@Maria1007 This email hit you because you are subscribed to repository updates. You don't need to do anything in particular about this.

If you dont' want to receive notification e-mails, you can press un-watch in the top-right bar
image

@learning-at-home learning-at-home deleted a comment from Maria1007 Sep 30, 2020
@mryab mryab closed this Oct 10, 2020
@mryab mryab deleted the faster_beam_search_part2 branch October 10, 2020 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants