This repository has been archived by the owner on Jan 10, 2023. It is now read-only.
Only activate after primary package has completed activation #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshrowley
reviewed
May 16, 2017
| expansionState: activationState.directoryExpansionStates | ||
| localRoot: _path.join(atom.configDirPath, '.learn-ide') | ||
| connection: | ||
| url: "#{WS_SERVER_URL}?token=#{token}&version=#{atomHelper.learnIdeVersion()}" |
There was a problem hiding this comment.
you can write this as:
atomHelper.waitForTerminalConnection()
.then(atomHelper.getToken)
.then((token) ->
nsync.configureif you wanna avoid nesting them through anonymous functions like that
you could even then wrap the nsync.configure call:
atomHelper.waitForTerminalConnection()
.then(atomHelper.getToken)
.then(nsync.configureFromToken)that function probably doesn't belong on the nsync object though since it's a specific detail on how nsync is used in this context
There was a problem hiding this comment.
I actually ended up reworking this a bit to handle errors better: https://github.com/learn-co/learn-ide-tree/pull/48/files#diff-23f01a445c8ded607cb8c67fbe954f90L200
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.