Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/encryption library #26

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Update/encryption library #26

merged 4 commits into from
Jun 13, 2024

Conversation

baryon2
Copy link
Collaborator

@baryon2 baryon2 commented Jun 13, 2024

Description of PR...

Changes

  1. Remove cryptojs
  2. Use noble ciphers for encryption

API Updates

New Features (required)

This section should include details regarding new features added to the library.
This should include both open and private APIs. If including both, create two
sub headers underneath this one to label updates accordingly.

Deprecations (required)

All deprecations should be listed here in order to ensure the reviewer understands
which sections of the codebase will affect contributors and users of the library.

Enhancements (optional)

The enhancements section should include code updates that were included with this
pull request. This sections should detail refactoring that might have affected
other parts of the library.

Checklist

  • Unit tests
  • Documentation

References

(optional)

Include important links regarding the implementation of this PR.
This usually includes and RFC or an aggregation of issues and/or individual conversations
that helped put this solution together. This helps ensure there is a good aggregation
of resources regarding the implementation.

Fixes #85, Fixes #22, Fixes username/repo#123
Connects #123

baryon2 and others added 3 commits April 18, 2024 16:14
1. Remove cryptojs
2. Use noble ciphers for encryption
@asanjeevrao
Copy link

Total Coverage: 0 %

Coverage report
File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 66.79 44.91 53.92 68.07
src 100 100 0 100
index.ts 100 100 0 100
src/crypto/bip32 72.22 100 50 72.22
hd-wallet.ts 66.66 100 50 66.66 6-10,22
hdwallet-token.ts 83.33 100 50 83.33 24
src/crypto/bip39 83.33 100 62.5 83.33
bip39-token.ts 100 100 100 100
bip39.ts 75 100 50 75 5,8,11
src/crypto/ecc 85.71 20 60 84.61
secp256k1.ts 85.71 20 60 84.61 13,28
src/crypto/hashes 77.77 100 0 71.42
hashes.ts 77.77 100 0 71.42 10,14
src/encryption-utils 100 75 100 100
encryption-utils.ts 100 75 100 100 50-66
src/key 53.43 22.41 53.48 55.26
eth-wallet.ts 43.52 30 36.84 46.83 39,93-164
wallet-utils.ts 96.77 76.92 100 96.66 43
wallet.ts 47.72 0 57.89 48.14 32-71,132-168
src/keychain 67.34 59.15 54.54 69.5
keychain.ts 67.34 59.15 54.54 69.5 35,68,76,131,162-198,221-251,311
src/storage 100 100 100 100
storage-layer.ts 100 100 100 100
src/types 100 100 100 100
keychain.ts 100 100 100 100
src/utils 62.96 42.85 44.44 62.74
correct-mnemonic.ts 66.66 100 0 100
encode-signature.ts 88.88 80 100 88.88 6
encoding.ts 88.88 0 100 87.5 3
get-hdpath.ts 100 50 100 100 1
init-crypto.ts 66.66 100 0 66.66 12-16
serialize-signdoc.ts 25 0 0 25 5-18,22-23,27
tests 100 100 100 100
mockdata.ts 100 100 100 100

@asanjeevrao
Copy link

Total Coverage: 0 %

Coverage report
File % Stmts % Branch % Funcs % Lines Uncovered Line #s
All files 66.79 44.91 53.92 68.07
src 100 100 0 100
index.ts 100 100 0 100
src/crypto/bip32 72.22 100 50 72.22
hd-wallet.ts 66.66 100 50 66.66 6-10,22
hdwallet-token.ts 83.33 100 50 83.33 24
src/crypto/bip39 83.33 100 62.5 83.33
bip39-token.ts 100 100 100 100
bip39.ts 75 100 50 75 5,8,11
src/crypto/ecc 85.71 20 60 84.61
secp256k1.ts 85.71 20 60 84.61 13,28
src/crypto/hashes 77.77 100 0 71.42
hashes.ts 77.77 100 0 71.42 10,14
src/encryption-utils 100 75 100 100
encryption-utils.ts 100 75 100 100 50-66
src/key 53.43 22.41 53.48 55.26
eth-wallet.ts 43.52 30 36.84 46.83 39,93-164
wallet-utils.ts 96.77 76.92 100 96.66 43
wallet.ts 47.72 0 57.89 48.14 32-71,132-168
src/keychain 67.34 59.15 54.54 69.5
keychain.ts 67.34 59.15 54.54 69.5 35,68,76,131,162-198,221-251,311
src/storage 100 100 100 100
storage-layer.ts 100 100 100 100
src/types 100 100 100 100
keychain.ts 100 100 100 100
src/utils 62.96 42.85 44.44 62.74
correct-mnemonic.ts 66.66 100 0 100
encode-signature.ts 88.88 80 100 88.88 6
encoding.ts 88.88 0 100 87.5 3
get-hdpath.ts 100 50 100 100 1
init-crypto.ts 66.66 100 0 66.66 12-16
serialize-signdoc.ts 25 0 0 25 5-18,22-23,27
tests 100 100 100 100
mockdata.ts 100 100 100 100

@baryon2 baryon2 merged commit 1f54e15 into staging Jun 13, 2024
6 checks passed
@baryon2 baryon2 deleted the update/encryption-library branch June 13, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants