Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate network to latest tendermint version #184

Closed
johannbarbie opened this issue Feb 23, 2019 · 3 comments
Closed

migrate network to latest tendermint version #184

johannbarbie opened this issue Feb 23, 2019 · 3 comments
Assignees
Labels
bounty size-XL effort of ~21h

Comments

@johannbarbie
Copy link
Member

Scope

Deliverables

  • new node release
  • upgraded testnet
  • upgraded mainnet (max 2 hours downtime for network)

Gain for the project

  • run latest secure software

Roles:

bounty gardener: @johannbarbie / 10%
bounty worker: name / share
bounty reviewer: name / share

@pinkiebell
Copy link
Contributor

We can also cherry-pick bug fixes, instead of merging the incompatible stuff :)

@pinkiebell
Copy link
Contributor

--- FAIL: TestStateLockPOLRelock (0.10s)
panic: Timeout expired while waiting for NewVote event [recovered]
	panic: Timeout expired while waiting for NewVote event

I have flaky tests, but the same happens on the v0.31.0 branch without our changes 😬

pinkiebell added a commit that referenced this issue Mar 21, 2019
A few small changes.

Fix create_empty_blocks and make sure we do not
submit duplicate validator (pubKey) entries to abci.

Related #184
pinkiebell added a commit to leapdao/tendermint-node that referenced this issue Mar 22, 2019
pinkiebell added a commit to leapdao/js-abci that referenced this issue Mar 22, 2019
@pinkiebell
Copy link
Contributor

troggy pushed a commit that referenced this issue Mar 26, 2019
A few small changes.

Fix create_empty_blocks and make sure we do not
submit duplicate validator (pubKey) entries to abci.

Related #184
troggy pushed a commit that referenced this issue Mar 28, 2019
* Support tendermint 0.31

A few small changes.

Fix create_empty_blocks and make sure we do not
submit duplicate validator (pubKey) entries to abci.

Related #184

* Upgrade js-abci,tendermint-node

- `abci.commit` returns *maybe* a wrong appHash,
  because returning nothing does not give empty blocks anymore
- Add a little timeout of 300ms to the period handler,
  this fixes a race condition if period submission is fast (from
  blockHandler)

* fix: --fresh option should preserve priv_validator_state.json

* upgrade tendermint-node

* update yarn.lock

* 4.2.0-beta.2

* use updated tendermint-node

* 4.2.0-beta.3

* v0.31.0-leap.2

* chore(cli): no need to fiddle with priv_validator_key.json on --fresh

the file is immutable in latest tendermints

* chore(cli): small refactoring for --fresh handler
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty size-XL effort of ~21h
Projects
None yet
Development

No branches or pull requests

2 participants