Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Lean.loadPlugin #6130

Merged
merged 8 commits into from
Nov 27, 2024
Merged

feat: Lean.loadPlugin #6130

merged 8 commits into from
Nov 27, 2024

Conversation

tydeu
Copy link
Member

@tydeu tydeu commented Nov 19, 2024

This PR adds Lean.loadPlugin which exposes functionality similar to the lean executable's --plugin option to Lean code.

This will allow custom Lean frontends (e.g., Lake, the Lean language server) to also load plugins.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 19, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 19, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 19, 2024
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Nov 19, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Nov 19, 2024

Mathlib CI status (docs):

@tydeu tydeu force-pushed the lean-load-plugin branch 2 times, most recently from 51cdb1d to 3643d5f Compare November 20, 2024 02:38
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 20, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 20, 2024
@tydeu tydeu added the release-ci Enable all CI checks for a PR, like is done for releases label Nov 20, 2024
@tydeu tydeu marked this pull request as ready for review November 20, 2024 03:52
@tydeu tydeu added the changelog-library Library label Nov 20, 2024
@tydeu tydeu marked this pull request as draft November 20, 2024 14:52
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 20, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 20, 2024
@tydeu tydeu force-pushed the lean-load-plugin branch 3 times, most recently from ea4437f to 666224d Compare November 20, 2024 17:52
@tydeu tydeu marked this pull request as ready for review November 20, 2024 19:15
@tydeu tydeu requested a review from Kha November 20, 2024 19:15
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 20, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 20, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 26, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 26, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 26, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 26, 2024
src/runtime/load_dynlib.cpp Outdated Show resolved Hide resolved
@Kha Kha enabled auto-merge November 27, 2024 08:40
@Kha Kha added this pull request to the merge queue Nov 27, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 27, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 27, 2024
Merged via the queue into leanprover:master with commit ac1197f Nov 27, 2024
23 checks passed
@tydeu tydeu deleted the lean-load-plugin branch November 28, 2024 07:23
JovanGerb pushed a commit to JovanGerb/lean4 that referenced this pull request Jan 21, 2025
This PR adds `Lean.loadPlugin` which exposes functionality similar to
the `lean` executable's `--plugin` option to Lean code.

This will allow custom Lean frontends (e.g., Lake, the Lean language
server) to also load plugins.

---------

Co-authored-by: Sebastian Ullrich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-library Library release-ci Enable all CI checks for a PR, like is done for releases toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants