Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup #6021

Merged
merged 2 commits into from
Nov 9, 2024
Merged

chore: cleanup #6021

merged 2 commits into from
Nov 9, 2024

Conversation

JovanGerb
Copy link
Contributor

This PR removes

  • a duplicate MonadMCtx instance in MetavarContext.lean
  • := return ← that I had left there accidentally in a previous PR.
  • the unnecessary application of mapMetaM in withTransparency.

@nomeata nomeata enabled auto-merge November 9, 2024 22:21
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 9, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 9, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 9, 2024
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Nov 9, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Nov 9, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Nov 9, 2024
@nomeata nomeata added this pull request to the merge queue Nov 9, 2024
Merged via the queue into leanprover:master with commit 811d8fb Nov 9, 2024
18 checks passed
@JovanGerb JovanGerb deleted the removeDupInstance branch November 10, 2024 01:14
@kim-em kim-em added the changelog-no Do not include this PR in the release changelog label Jan 4, 2025
JovanGerb added a commit to JovanGerb/lean4 that referenced this pull request Jan 21, 2025
This PR removes
- a duplicate `MonadMCtx` instance in `MetavarContext.lean`
- `:= return ←` that I had left there accidentally in a previous PR.
- the unnecessary application of `mapMetaM` in `withTransparency`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changelog-no Do not include this PR in the release changelog toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants