fix: .. in patterns should not make use of optparams or autoparams
#5933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In patterns, ellipsis should always be an implicit argument, even if it is an optparam or autoparam. This prevents examples such as the one in leanprover#4555 from failing: ```lean match e with | .internal .. => sorry | .error .. => sorry ``` The `internal` constructor has an optparam (`| internal (id : InternalExceptionId) (extra : KVMap := {})`). We may consider having ellipsis suppress optparams and autoparams in general. We avoid doing so for now since it's possible to opt-out of them individually (for example with `.internal (extra := _) ..`) but it's not possible to opt-in. While we can opt-out like this for patterns as well, with patterns it is suprising how strongly the optparams are inserted. Closes leanprover#4555
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 3, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 3, 2024
leanprover-community-bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In patterns, ellipsis should always fill in each remaining argument as an implicit argument, even if it is an optparam or autoparam. This prevents examples such as the one in #4555 from failing:
The
internalconstructor has an optparam (| internal (id : InternalExceptionId) (extra : KVMap := {})).We may consider having ellipsis suppress optparams and autoparams in general. We avoid doing so for now since it's possible to opt-out of them individually (for example with
.internal (extra := _) ..) but it's not possible to opt-in, and it is plausible that..with optparams is useful in contexts such as therefinetactic. With patterns however, it is hard to imagine a use case that offsets the inconvenience of optparams being eagerly supplied.Closes #4555