Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add BitVec.sdiv_[zero|one|self] theorems #5718

Merged
merged 10 commits into from
Oct 15, 2024
Merged

feat: add BitVec.sdiv_[zero|one|self] theorems #5718

merged 10 commits into from
Oct 15, 2024

Conversation

tobiasgrosser
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 15, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 15, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 0bfe1a8c1a2e2eb6da0dad270d7b2bbdd5b97c3d --onto 225e08965d644715e8961cd205ffedf1cf7d24c2. (2024-10-15 04:58:54)
  • ❗ Batteries CI can not be attempted yet, as the nightly-testing-2024-10-15 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Batteries CI should run now. (2024-10-15 08:52:28)

bollu
bollu approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor

@bollu bollu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

hargoniX
hargoniX requested changes Oct 15, 2024
View reviewed changes
src/Init/Data/BitVec/Lemmas.lean Outdated Show resolved Hide resolved
src/Init/Data/BitVec/Lemmas.lean Outdated Show resolved Hide resolved
@tobiasgrosser
Copy link
Contributor Author

This should now be ready to go.

@hargoniX hargoniX added this pull request to the merge queue Oct 15, 2024
Merged via the queue into leanprover:master with commit 7234ab7 Oct 15, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hargoniX hargoniX hargoniX requested changes

@bollu bollu bollu approved these changes

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tobiasgrosser @leanprover-community-bot @bollu @hargoniX