Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make @[elab_as_elim] require at least one discriminant #5671

Merged
merged 1 commit into from
Oct 10, 2024
Merged

fix: make @[elab_as_elim] require at least one discriminant #5671

merged 1 commit into from
Oct 10, 2024

Conversation

kmill
Copy link
Collaborator

@kmill kmill commented Oct 10, 2024

This is an oversight in getElabElimExprInfo. If there are no discriminants, then there is no point in elaborating as an eliminator.

@kmill
fix: make @[elab_as_elim] require at least one discriminant
d752a4f 
This is an oversight in `getElabElimExprInfo`. If there are no discriminants, then there is no point in elaborating as an eliminator.
@kmill kmill enabled auto-merge October 10, 2024 16:58
@kmill kmill added this pull request to the merge queue Oct 10, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 10, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 3930100b67d2dd14a62412432f8822b29a9900af --onto b814be6d6a5334784b172db15fd7fea39b4e3233. (2024-10-10 17:23:45)

Merged via the queue into leanprover:master with commit 4614b75 Oct 10, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kmill @leanprover-community-bot