Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: simpproc to reduce Fin literals consistently #5632

Merged
merged 1 commit into from
Oct 15, 2024
Merged

fix: simpproc to reduce Fin literals consistently #5632

merged 1 commit into from
Oct 15, 2024

Conversation

nomeata
Copy link
Collaborator

@nomeata nomeata commented Oct 7, 2024

previously, it would not reduce 25 : Fin 25 to 0 : Fin 25.

fixes #5630

@nomeata
fix: simpproc to reduce Fin literals consistencies
90125cf 
previously, it would not reduce `25 : Fin 25` to  `0 : Fin 25`.

fixes #5630
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc October 7, 2024 13:48 Inactive
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Oct 7, 2024
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Oct 7, 2024 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries CI can not be attempted yet, as the nightly-testing-2024-10-07 tag does not exist there yet. We will retry when you push more commits. If you rebase your branch onto nightly-with-mathlib, Batteries CI should run now. (2024-10-07 14:01:41)
  • ✅ Mathlib branch lean-pr-testing-5632 has successfully built against this PR. (2024-10-07 18:36:08) View Log

@nomeata nomeata added merge-ci Enable merge queue CI checks for PR. In particular, produce artifacts for all major platforms. and removed merge-ci Enable merge queue CI checks for PR. In particular, produce artifacts for all major platforms. labels Oct 7, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Oct 7, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5632
521c282
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Oct 7, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5632
e1970f9
@leanprover-community-bot leanprover-community-bot added the builds-mathlib CI has verified that Mathlib builds against this PR label Oct 7, 2024
@nomeata nomeata changed the title fix: simpproc to reduce Fin literals consistencies fix: simpproc to reduce Fin literals consistently Oct 8, 2024
@nomeata nomeata marked this pull request as ready for review October 8, 2024 14:43
@nomeata nomeata requested a review from leodemoura as a code owner October 8, 2024 14:44
@nomeata nomeata added the will-merge-soon …unless someone speaks up label Oct 8, 2024
@nomeata nomeata added this pull request to the merge queue Oct 15, 2024
Merged via the queue into master with commit 94b1e51 Oct 15, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN will-merge-soon …unless someone speaks up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

simp usually reduces Fin n literals, but not n itself
2 participants
@nomeata @leanprover-community-bot