Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: rename List.maximum? to max? #5518

Merged
merged 1 commit into from
Sep 29, 2024
Merged

chore: rename List.maximum? to max? #5518

merged 1 commit into from
Sep 29, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Sep 29, 2024

More consistent with other API.

@kim-em kim-em enabled auto-merge September 29, 2024 06:04
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc September 29, 2024 06:22 Inactive
@kim-em kim-em added this pull request to the merge queue Sep 29, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 29, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 96adf04a62fcbd48b7ddc51829b76bd161153c73 --onto 9460f79d28d3a72d7484766b5f2c83362e91dd5b. (2024-09-29 06:25:24)

Merged via the queue into master with commit d96b7a7 Sep 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwoFX TwoFX Awaiting requested review from TwoFX

@digama0 digama0 Awaiting requested review from digama0 digama0 is a code owner

@mhuisi mhuisi Awaiting requested review from mhuisi mhuisi is a code owner

Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kim-em @leanprover-community-bot