-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: BitVec.Lemmas - drop non-terminal simps #5499
Conversation
7dbf697
to
df3a5da
Compare
Mathlib CI status (docs):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this PR supposed to address all of them or only the ones seen here? If it is all of them, did you verify with e.g. grep simp | grep -v "simp only"
that you got all of them?
I searched now for |
BitVec.Lemmas
contained a couple of non-terminal simps. We turn non-terminalsimp$
,simp [
, andsimp at
expressions intosimp only
to improve code maintainability.