Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fin.ofNat' uses NeZero #5356

Merged
merged 3 commits into from
Sep 16, 2024
Merged

chore: Fin.ofNat' uses NeZero #5356

merged 3 commits into from
Sep 16, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Sep 16, 2024

No description provided.

@kim-em kim-em added the awaiting-mathlib We should not merge this until we have a successful Mathlib build label Sep 16, 2024
@kim-em kim-em requested a review from leodemoura as a code owner September 16, 2024 03:31
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Sep 16, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 16, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5356
894eca9
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 16, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5356
335c08c
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Sep 16, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc September 16, 2024 05:00 Inactive
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 16, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5356
10a5c01
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 16, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5356
e34148d
@kim-em kim-em removed the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Sep 16, 2024
kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 16, 2024
@kim-em
fixes for leanprover/lean4#5356
15cdbb1
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Sep 16, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@kim-em kim-em removed the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Sep 16, 2024
@kim-em kim-em changed the title chore: Fin.onNat' uses NeZero chore: Fin.ofNat' uses NeZero Sep 16, 2024
@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed awaiting-mathlib We should not merge this until we have a successful Mathlib build labels Sep 16, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@kim-em kim-em added this pull request to the merge queue Sep 16, 2024
Merged via the queue into master with commit c25d206 Sep 16, 2024
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kim-em @leanprover-community-bot