Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Bool namespacing #5351

Merged
merged 5 commits into from
Sep 16, 2024
Merged

feat: Bool namespacing #5351

merged 5 commits into from
Sep 16, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Sep 15, 2024

Remove _root_.and (also or/not/xor) and instead export/use Bool.and.

@github-actions github-actions bot added changes-stage0 Contains stage0 changes, merge manually using rebase toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN labels Sep 15, 2024
leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 16, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5351
93af39d
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 16, 2024
@leanprover-community-mathlib4-bot
Update lean-toolchain for testing leanprover/lean4#5351
2140850
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Sep 16, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 16, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5351
2e8754c
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 16, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5351
a363b87
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc September 16, 2024 00:29 Inactive
@kim-em kim-em added awaiting-mathlib We should not merge this until we have a successful Mathlib build and removed breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan labels Sep 16, 2024
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc September 16, 2024 00:38 Inactive
@leanprover-community-bot leanprover-community-bot added the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Sep 16, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

leanprover-community-mathlib4-bot added a commit to leanprover-community/batteries that referenced this pull request Sep 16, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5351
5e5f37d
leanprover-community-mathlib4-bot added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 16, 2024
@leanprover-community-mathlib4-bot
Trigger CI for leanprover/lean4#5351
ceedc06
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

kim-em added a commit to leanprover-community/mathlib4 that referenced this pull request Sep 16, 2024
@kim-em
fixes for leanprover/lean4#5351
53f6a16
@kim-em kim-em removed the breaks-mathlib This is not necessarily a blocker for merging: but there needs to be a plan label Sep 16, 2024
@leanprover-community-bot leanprover-community-bot added builds-mathlib CI has verified that Mathlib builds against this PR and removed awaiting-mathlib We should not merge this until we have a successful Mathlib build labels Sep 16, 2024
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

@kim-em kim-em merged commit 8c6ac84 into master Sep 16, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hargoniX hargoniX Awaiting requested review from hargoniX hargoniX is a code owner

@TwoFX TwoFX Awaiting requested review from TwoFX

@digama0 digama0 Awaiting requested review from digama0

@kmill kmill Awaiting requested review from kmill kmill is a code owner

@leodemoura leodemoura Awaiting requested review from leodemoura leodemoura is a code owner

@tydeu tydeu Awaiting requested review from tydeu

Assignees
No one assigned
Labels
builds-mathlib CI has verified that Mathlib builds against this PR changes-stage0 Contains stage0 changes, merge manually using rebase toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kim-em @leanprover-community-bot