Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: List.getElem_drop, add @[simp] and switch primes #5210

Merged
merged 1 commit into from
Aug 30, 2024
Merged

chore: List.getElem_drop, add @[simp] and switch primes #5210

merged 1 commit into from
Aug 30, 2024

Conversation

kim-em
Copy link
Collaborator

@kim-em kim-em commented Aug 30, 2024

This is a breaking change, as it reverses the meaning of List.getElem_drop and List.getElem_drop'.

@kim-em kim-em enabled auto-merge August 30, 2024 02:28
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc August 30, 2024 02:38 Inactive
@kim-em kim-em added this pull request to the merge queue Aug 30, 2024
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 30, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase f30ff6ae798447b7a2caa018e24ea8431b7d8112 --onto 9ce15fb0c61e3a1bee17fd81647ed4d02b4f6c6d. (2024-08-30 02:51:46)

Merged via the queue into master with commit 0a0405f Aug 30, 2024
14 checks passed
@kim-em kim-em deleted the getElem_drop branch August 30, 2024 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kim-em @leanprover-community-mathlib4-bot