fix: get_elem_tactic_trivial to not loop in the presence of mvars
#5119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The goal at the crucial step is ``` a : Array Nat i : Fin ?m.27 ⊢ ↑i < a.size ``` and after the `apply Fin.val_lt_of_le;` we have ``` a : Array Nat i : Fin ?m.27 ⊢ ?m.27 ≤ a.size ``` and now `apply Fin.val_lt_of_le` applies again, due to accidential defeq. Adding `with_reducible` helps here. fixes #5061
github-actions
bot
added
the
toolchain-available
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Aug 21, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Aug 21, 2024
leanprover-community-mathlib4-bot
added
the
builds-mathlib
|
Mathlib CI status (docs):
|
Kha
reviewed
Aug 22, 2024
| @@ -184,7 +184,7 @@ instance [GetElem? cont Nat elem dom] [h : LawfulGetElem cont Nat elem dom] : | |||
| @[simp] theorem getElem!_fin [GetElem? Cont Nat Elem Dom] (a : Cont) (i : Fin n) [Inhabited Elem] : a[i]! = a[i.1]! := rfl | |||
|
|
|||
| macro_rules | |||
| | `(tactic| get_elem_tactic_trivial) => `(tactic| apply Fin.val_lt_of_le; get_elem_tactic_trivial; done) | |||
| | `(tactic| get_elem_tactic_trivial) => `(tactic| (with_reducible apply Fin.val_lt_of_le); get_elem_tactic_trivial; done) | |||
There was a problem hiding this comment.
An explanatory comment seems to be missing here :)
There was a problem hiding this comment.
Hmm, maybe. Although with_reducible itself already shuts loudly “don't apply this lemma unless the goals looks like it”, and brings this in line with similar tactic invocations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal at the crucial step is
and after the
apply Fin.val_lt_of_le;we haveand now
apply Fin.val_lt_of_leapplies again, due to accidential defeq. Addingwith_reduciblehelps here.fixes #5061