Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: mark entire reported info tree as persistent #5040

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

Kha
Copy link
Member

@Kha Kha commented Aug 14, 2024

As we can definitely not free it until .ilean generation at the very end

@Kha
Copy link
Member Author

Kha commented Aug 14, 2024

!bench

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Aug 14, 2024
@leanprover-community-mathlib4-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 958ad2b54bc7151dfc702e9a85a32584c2f49cca --onto f3e7b455bbd4ea39376e0928d0d6cb8d26bd0ba3. (2024-08-14 12:49:48)

@leanprover-bot
Copy link
Collaborator

Here are the benchmark results for commit 225335d.
There were significant changes against commit 958ad2b:

  Benchmark          Metric       Change
  ================================================
+ lake build clean   task-clock    -4.2% (-11.6 σ)

@Kha Kha marked this pull request as ready for review August 14, 2024 13:39
@Kha Kha added this pull request to the merge queue Aug 14, 2024
Merged via the queue into leanprover:master with commit 20a7fe8 Aug 14, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants