feat: ushiftRight bitblasting #4872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
bollu
force-pushed
the
upstream-ushiftRight-recurrence
branch
4 times, most recently
from
2806cc2 to
9c52520
Compare
bollu
force-pushed
the
upstream-ushiftRight-recurrence
branch
from
9c52520 to
9d79e69
Compare
|
Mathlib CI status (docs):
|
|
Nice. Let's wait for @alexkeizer feedback and then this can be undrafted. |
|
LGTM. |
Co-authored-by: Tobias Grosser <[email protected]>
Co-authored-by: Tobias Grosser <[email protected]>
|
@semorrison I'm not going to mark it |
bollu
added a commit
to opencompl/lean4
that referenced
this pull request
Jul 31, 2024
This mimics leanprover#4872 for arithmetic shift right. This adds theorems sshiftRight_rec_zero, sshiftRight_rec_succ, sshiftRight_rec_eq, and shiftRight_eq_shiftRight_rec.
bollu
added a commit
to opencompl/lean4
that referenced
this pull request
Jul 31, 2024
This mimics leanprover#4872 for arithmetic shift right. This adds theorems sshiftRight_rec_zero, sshiftRight_rec_succ, sshiftRight_rec_eq, and shiftRight_eq_shiftRight_rec.
bollu
added a commit
to opencompl/lean4
that referenced
this pull request
Jul 31, 2024
This mimics leanprover#4872 for arithmetic shift right. This adds theorems sshiftRight_rec_zero, sshiftRight_rec_succ, sshiftRight_rec_eq, and shiftRight_eq_shiftRight_rec.
bollu
added a commit
to opencompl/lean4
that referenced
this pull request
Jul 31, 2024
This mimics leanprover#4872 for arithmetic shift right. This adds theorems sshiftRight_rec_zero, sshiftRight_rec_succ, sshiftRight_rec_eq, and shiftRight_eq_shiftRight_rec.
bollu
added a commit
to opencompl/lean4
that referenced
this pull request
Jul 31, 2024
This mimics leanprover#4872 for arithmetic shift right. This adds theorems sshiftRight_rec_zero, sshiftRight_rec_succ, sshiftRight_rec_eq, and shiftRight_eq_shiftRight_rec.
|
Review from Alex no longer necessary after some internal communication. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 7, 2024
We follow the same strategy as #4872, #4571, and implement bitblasting theorems for `sshiftRight`. --------- Co-authored-by: Tobias Grosser <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds theorems
ushiftRight_rec_zero,ushiftRight_rec_succ,ushiftRight_rec_eq, andshiftRight_eq_shiftRight_rec.