refactor: IndPredBelow: use apply_assumption
#4841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when transforming the `match` statements in `IndPredBelow`, given a local variable `x : T`, we need to search for `hx : T.below x`. Previously this was done using the custom `backwardsChaining` method, although my hypothesis is that we don’t need to chain anything here, and can use `apply_assumption`.
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Jul 27, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Jul 27, 2024
leanprover-community-mathlib4-bot
added
the
builds-mathlib
|
@DanielFabian. Here too: It seems that backwards chaining is more powerful than we need here. WDYT of this change, to make it more clear that we don’t expect recursive search here? Or would you suggest to not change this code without a clear need at this point? |
|
I'm all for simplifying and even deleting backwards chaining if we can get rid of it. I built it initially because in those days the automation features were not quite there yet and it was an easy enough tactic to build. But I'm in no way attached to it. We have our motivating examples in the unit tests, imo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when transforming the
matchstatements inIndPredBelow, given alocal variable
x : T, we need to search forhx : T.below x.Previously this was done using the custom
backwardsChainingmethod,although my hypothesis is that we don’t need to chain anything here, and
can use
apply_assumption.